Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumed latest changes from core, use QueryPhaseSearcherWrapper as parent class for Hybrid QPS #356

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Consumed latest changes from core, use QueryPhaseSearcherWrapper as parent class for Hybrid QPS #356

merged 1 commit into from
Sep 29, 2023

Conversation

martin-gaievski
Copy link
Member

Description

Need to use QueryPhaseSearcherWrapper as this is core new public implementation of the QueryPhaseSearcher. This will be released in core 2.11, came with this PR.

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch Maintenance Add support for new versions of OpenSearch/Dashboards from upstream labels Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #356 (6f78c6e) into main (67ced0d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #356      +/-   ##
============================================
+ Coverage     84.56%   84.57%   +0.01%     
  Complexity      427      427              
============================================
  Files            35       35              
  Lines          1289     1290       +1     
  Branches        189      189              
============================================
+ Hits           1090     1091       +1     
  Misses          118      118              
  Partials         81       81
Files Coverage Δ
...lsearch/search/query/HybridQueryPhaseSearcher.java 71.76% <100.00%> (+0.33%) ⬆️

@martin-gaievski
Made hybrid QPS extending QueryPhaseSearcherWrapper
6f78c6e 
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski force-pushed the use-latest-core-wrapper-for-queryphasesearcher branch from 8343c38 to 6f78c6e Compare September 29, 2023 18:54
@martin-gaievski martin-gaievski marked this pull request as ready for review September 29, 2023 18:55
@martin-gaievski martin-gaievski added the v2.11.0 Issues targeting release v2.11.0 label Sep 29, 2023
vamshin
vamshin approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@navneet1v
Copy link
Collaborator

@martin-gaievski should we have a check with concurrent segment search enabled? what do you think?

@martin-gaievski
Copy link
Member Author

@martin-gaievski should we have a check with concurrent segment search enabled? what do you think?

we definitely need to check that, do you mean check manually or add a test for this?

@heemin32
Copy link
Collaborator

@martin-gaievski should we have a check with concurrent segment search enabled? what do you think?

I believe, it should be safe to assume that concurrent search is disabled.

@navneet1v
Copy link
Collaborator

@martin-gaievski should we have a check with concurrent segment search enabled? what do you think?

we definitely need to check that, do you mean check manually or add a test for this?

The thing is concurrent search is not GA, I think we can skip for now. But Last when I checked by enabling the concurrent search our tests failed. Now I am hoping when concurrent search will become GA they will ask all plugins to validate.

@navneet1v navneet1v merged commit 2c5d150 into opensearch-project:main Sep 29, 2023
31 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 29, 2023
@martin-gaievski @github-actions
Made hybrid QPS extending QueryPhaseSearcherWrapper (#356)
2cac919 
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit 2c5d150)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 29, 2023
Merged
martin-gaievski added a commit that referenced this pull request Sep 29, 2023
@opensearch-trigger-bot @martin-gaievski
Made hybrid QPS extending QueryPhaseSearcherWrapper (#356) (#364)
9e12de8 
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
(cherry picked from commit 2c5d150)

Co-authored-by: Martin Gaievski <gaievski@amazon.com>
@jed326 jed326 mentioned this pull request Jun 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamshin vamshin vamshin approved these changes

@navneet1v navneet1v navneet1v approved these changes

@heemin32 heemin32 heemin32 approved these changes

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@wujunshen wujunshen Awaiting requested review from wujunshen

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn

@jngz-es jngz-es Awaiting requested review from jngz-es

Assignees
No one assigned
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch Maintenance Add support for new versions of OpenSearch/Dashboards from upstream v2.11.0 Issues targeting release v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin-gaievski @navneet1v @heemin32 @vamshin